HH-216278 small fixes #703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
712u3
commented
May 17, 2024
| @@ -49,14 +50,18 @@ class FrontikApplication: | |||
| class DefaultConfig: | |||
| pass | |||
|
|
|||
| def __init__(self, app_root: str, **settings: Any) -> None: | |||
| def __init__(self, app_module_name: Optional[str] = None) -> None: | |||
There was a problem hiding this comment.
в тестах неудобно по 100 параметров задавать app/app_class/app_module/app_root + мупи очень тяжело было объяснить что где-то что-то не None
сделал 1 параметр
712u3
commented
May 17, 2024
| def is_finished(self) -> bool: | ||
| return self._finished | ||
|
|
||
| def abort(self) -> None: |
There was a problem hiding this comment.
уже давно все логи заспамлены лишними ошибками AbortAsyncGroup
упростил финиш группу
712u3
force-pushed
the
HH-216278
branch
2 times, most recently
from
906baeb
to
8190e6d
Compare
bokshitsky
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.hh.ru/browse/HH-216278